Deprecate XHRInterceptor and WebSocketInterceptor APIs#54869
Closed
huntie wants to merge 1 commit intofacebook:mainfrom
Closed
Deprecate XHRInterceptor and WebSocketInterceptor APIs#54869huntie wants to merge 1 commit intofacebook:mainfrom
huntie wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: These APIs are unused within React Native since facebook#54868, and we now implement the `Network` CDP domain in core (React Native DevTools and other CDP clients). These APIs are private under the Strict TypeScript API, however have some open source usages in Reactotron and Rozenite, which is why we aren't removing these immediately. We intend to remove these APIs in future, but with no immediate planned timeline. Changelog: [General][Deprecated] - Deprecate `XHRInterceptor` and `WebSocketInterceptor` APIs. Developer tools should use the CDP `Network` domain instead. Reviewed By: vzaidman, javache Differential Revision: D89051528
e8ea45b to
e4150b2
Compare
|
This pull request has been merged in 41380f3. |
Collaborator
|
This pull request was successfully merged by @huntie in 41380f3 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
These APIs are unused within React Native since #54868, and we now implement the
NetworkCDP domain in core (React Native DevTools and other CDP clients).These APIs are private under the Strict TypeScript API, however have some open source usages in Reactotron and Rozenite, which is why we aren't removing these immediately.
We intend to remove these APIs in future, but with no immediate planned timeline.
Changelog:
[General][Deprecated] - Deprecate
XHRInterceptorandWebSocketInterceptorAPIs. Developer tools should use the CDPNetworkdomain instead.Differential Revision: D89051528